避免 menuCommand 更新在 Tab 移除后触发#828
Merged
CodFrm merged 2 commits intoscriptscat:mainfrom Oct 10, 2025
Hidden character warning
The head ref may contain hidden characters: "\u907f\u514d-menuCommand-\u66f4\u65b0\u5728-Tab-\u79fb\u9664\u540e\u89e6\u53d1-1"
Merged
Conversation
CodFrm
reviewed
Oct 10, 2025
| // 避免 menuCommand 更新在 Tab 移除后触发 | ||
| list.length = 0; | ||
| this.updateMenuCommands.delete(tabId); | ||
| } |
Member
There was a problem hiding this comment.
我理解 this.updateMenuCommand 在 updateMenuCommand 最后面肯定会删除的，且updateMenuCommand是一个同步函数，这实际是一个无效操作
Collaborator
Author
There was a problem hiding this comment.
呀。原来现在是 ScriptMenu 没删 （${CACHE_KEY_TAB_SCRIPT}${tabId}）
对。会跑。所以如果推了10个registerMenu, onRemoved 后才执行，那么就会变成在 script.menus 里残留
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
之前原案有這個，改動後消失了。補回去